89 replies to this topic

[jpsalas]

Thanks JP. This table is really fun to play. I'll periodically post any bugs I find in this release thread unless you want them personally sent to your e-mail address instead. I'll post the first bug here.

Once you defeat the captain, the 2 sound samples, "vo_captaindefeated" and "vo_fightkraken" overlap one another.
Changing "KrakenDelay" from 20 to 50 in the CheckCaptain Sub will fix this.

Yes, please, just post the bugs here

JP

[Itchigo]

Just tried this for the first time, very fun game! I'm amazed at what JP has put into this. One thing that stands out to me is the gameplay! The slingshots in particular play as real to me. I've only played one game so I'm sure I'll get better at it, but is this any good?
Monk who?

Attached Files

•  Untitled.jpg   769.27KB   50 downloads

Edited by Itchigo, 04 February 2012 - 03:40 PM.

[RipleYYY]

lol

[sast05]

Another sound bug:

When you complete the six green standup targets (The Pirate's Skulls), the random pirates quote plays at the same time you hear the sample "vo_greenskullscompleted". The following change will prevent the two samples from playing at the same time.


Here is the modified SUB:

CODE

$Sub CheckGreenSkulls
    Dim x, tmp
    tmp = 0
    For x = 0 to 5
        tmp = tmp + GreenSkulls(x)
    Next
    If tmp = 6 Then                                                      'green skulls completed
        If PiratesCompleted = 0 Then PlaySound "vo_greenskullscompleted" 'play only the first time
        If PiratesCompleted = 1 Then PlayPiratesQuote
        PiratesCompleted = 1
        Addscore GreenSkullValue
        l9.State = 1
        CheckSouth
        StartLiarsDice
        NewGreenSkulls
    Else
        PlayPiratesQuote
    End If
End Sub
;

[bzs]

THX!!!

[wtiger]

Wow, very nice. Thanks JP!

[sast05]

To date, what I have found with "Pirates Wolves of the Sea"

Once you defeat the captain, the 2 sound samples, "vo_captaindefeated" and "vo_fightkraken" overlap one another.
Changing "KrakenDelay" from 20 to 50 in the CheckCaptain Sub will fix this.

CODE

Sub CheckCaptain
    AddScore CaptainValue  ' Captain has been hit
    CaptainLife = CaptainLife - CaptainHitValue
    If CaptainLife <0 Then 'Captain's defeated
        DisplayFlushQueue
        DisplayQueueScreen "THE CAPTAIN HAS ", "  BEEN DEFEATED", eBlinkFast, eBlinkFast, 0, 1000, True, "vo_captaindefeated"
        AddScore CaptainValue * 10
        CaptainValue = CaptainValue * 2
        EndCaptain
        l31.State = 1
        l7.State = 1:CheckEast
        KrakenDelay = 50
    End If
End Sub;

When you complete the six green standup targets (The Pirate's Skulls), the random "pirates quote" plays at the same time you hear the sample "vo_greenskullscompleted". The following change will prevent the two samples from playing at the same time.

CODE

$Sub CheckGreenSkulls
    Dim x, tmp
    tmp = 0
    For x = 0 to 5
        tmp = tmp + GreenSkulls(x)
    Next
            If tmp = 6 Then                                                      'green skulls completed
              If PiratesCompleted = 0 Then PlaySound "vo_greenskullscompleted" 'play only the first time
                      If PiratesCompleted = 1 Then PlayPiratesQuote
                      PiratesCompleted = 1
              Addscore GreenSkullValue
              l9.State = 1
              CheckSouth
              StartLiarsDice
              NewGreenSkulls
    Else
                      PlayPiratesQuote
           End If
End Sub;

When you start the table for the first time, it initializes just fine, but when you restart the table for all successive games, not everything initializes the way it should.
In Sub_Initialize you need to add "ResetChestKeys" and "ResetChest" to close the chest and turn off the key lamps for the next game.

CODE

$Sub Initialize ' First Ball
    ResetLights
    Score = 0
    Bonus = 0
    BallsRemaining = BallsPerGame + 1 ' first ball
    BallsOnPlayfield = 0
    BallsInLock = 0
    BallSaved = 0
    BonusMultiplier = 1
    MultiballDelay = 0
    TiltDelay = 0
    Tilted = False
    Tilt = 0
    Special = 0
    AutoPlungerDelay = 0
    AutoPlungerReady = 0
    MultiBallMode = 0
    GameStarted = 1
    PlaySong "m_plunger2"
    If Firsttime = 0 Then PlaySound "vo_welcome":Firsttime = 1
    ' Reset Modes
    StartSkillshot
    ResetOutlanes
    ComboValue = 250000
    ResetCombo
    GreenKeyValue = 500000
    ResetGreenKeys
    CenterValue = 250000
    ResetShip
    ResetKraken
    Reset3M
    ResetCaptain
    ResetSwordFight
    ResetNorth
    ResetSkull
    Reset2M
    ResetExtraBall
    ResetSpecial
    ResetPortRoyal
    ResetGreenSkulls
    ResetSouth
    ResetJackpotMode
    ResetLiarsDice
    ResetEast
    Reset4Winds
    ResetTreasure
    ResetInlanes
    ResetBonusHeld
            ResetChest
            ResetChestKeys
End Sub;

In Sub_ResetTreasure you need to add "l18.state=0" and "l20.state=0" to reset lamps l18 and l20 for the start of a new game.

CODE

$Sub ResetTreasure
    TreasureCollected = 0
            l18.state=0
            l20.state=0
End Sub;

There's a major typo in the script preventing you from playing the wizard mode (4 Winds Multiball).
Change "l2.State=1" to "l52.State=1"

CODE

$Sub Check4Winds 'check all the wheel lights are on
    If FourWindsStarted Then
        AwardSuperJackpot
    Else
        If LastSwitchHit = "sw16" AND l49.State = 1 AND l50.State = 1 AND l51.State = 1 AND l2.State = 1 Then
            Start4Winds
        End If
    End If
End Sub;

One more major issue:

There are no calls to the subroutine CheckNorth so it is impossible to start and complete "Collect Crew" . Without it you cannot meet the north requirement for 4 Winds Multiball (Wizard Mode).

I think the calls should go here:

CODE

$Sub ShipDestroyed
    SetLamp 90, 0, 2, 30:SetLamp 91, 0, 2, 30:SetLamp 92, 0, 2, 30:SetLamp 93, 0, 2, 30:SetLamp 94, 0, 2, 30
    SetLamp 95, 0, 2, 30:SetLamp 96, 0, 2, 30:SetLamp 97, 0, 2, 30:SetLamp 98, 0, 2, 30:SetLamp 99, 0, 2, 30
    Dim scoretmp
    Ship1.IsDropped = 1:Ship2.IsDropped = 1:Ship3.IsDropped = 1:Ship4.IsDropped = 1
    l5.State = 1
    scoretmp = 150000 + 50000 * ShipsSunk
    DisplayFlushQueue
    DisplayQueueScreen " SHIP DESTROYED ", FormatScore(scoretmp) & "       ", eNone, eBlinkFast, 0, 500, True, "vo_sunkship"
    Addscore scoretmp
                CheckNorth
    CaptainDelay = 40
End Sub

and Here:

CODE

$Sub CheckSwordFight 'a bumper has been hit then check for the sword fight and increase the bonus multiplier
    Dim tmp
    SFHits = SFHits + 1

    tmp = INT(RND(1) * 3) 'play a sword sound
    Select Case tmp
        Case 0:PlaySound "fx_sword1"
        Case 1:PlaySound "fx_sword2"
        Case 2:PlaySound "fx_sword3"
    End Select

    If SFHits MOD 20 = 0 Then 'increase bonus multiplier after 20 hits
        BonusMultiplier = BonusMultiplier + 1
        BumperAward = BumperAward + 250
    End If
    If SFHits = 200 Then PlaySound "vo_swordcompleted":l6.State = 1:CheckNorth 'Sword Fight completed
End Sub

JP, you better check that out carefully to be sure. I think there are some sound issues as well with that as well.

That's all I can find for now- For such a complex game, there is a lot to try out.
Thanks JP for this great Original!

P.S. I'm still trying to isolate and fix the problem with the extra ball, it happens only once in a great while.
Also when I get six balls going all at once, wierd things start happening. Is their some way to limit the ball to 4 on the playfield?

Edited by sast05, 05 February 2012 - 03:30 AM.

[FDSystems]

sast05 should be nominated Bugfinder in Chief or Head Script Analizer or more simply VIP, imho.

Just my two cents.

Thanks sast05.

[jpsalas]

Thanks sast05! I'll check those bugs and I'll add the fixes for the next update.

JP

[jpsalas]

Update 101:

Added the bug fixes by sast05

[Pintrepid]

Well, shiver me timbers and blow me down, if it ain't another super ultra mega blockbuster hit from Mr Pinball himself!

Thanks for this table, JP!! Can't seem to stop playing it!! (when I'm not still playing Flash, that is )

BTW ... once upon a time, pinball tables had only 4 scoring reels in their back boxes. Well, maybe by the time I started playing 'em they had 6 reels. And a mere quarter got you two games at 5 balls each. If you hit 100k, you heard the solid THWACK!!! letting you know that you earned the Special.

But nowadays, without even trying, I reached 347,849,243 .. on the first ball! When the ball bounced around between the bumpers, that alone earned 637,239!

Times are just not simple anymore

-PeterM

[jpsalas]

Yeah, I know what you mean I remember when my computer had 32Mb memory, and I though I would never need more memory. Windows 95 was so happy with just 8Mb

[bolt]

Thank you sast05 for the help and JP for the update.

[sast05]

A few more issues came up with the scripting and logic:

There were a few instances where the "shoot again" light did not come on.
Added "l1.state = 1" to CheckExtraBallSub & added "l1.state = 0" to Sub Drain_Hit

Sub CheckExtraBall
If Extraball Then 'give an extra ball
PlaySound "knocker"
ExtraBallAwarded = 1
l1.state = 1
DisplayQueueScreen "-", " EXTRA BALL ", eNone, eNone, 0, 500, TRUE, "vo_extraball"
EndExtraBall
End If
End Sub


If GameStarted AND NOT Tilted Then
If BallSaved OR ExtraBallAwarded Then
DisplayQueueScreen " BALL SAVED", " SHOOT AGAIN", eNone, eBlink, 0, 1000, True, "vo_ballsaved"
ShootAgainOff
BallsRemaining = BallsRemaining + 1 'add the extra ball
ExtraBallAwarded = 0
l1.state = 0
BallSaved = 0
SkillshotReady = 0
AutoPlungerReady = 1
NextBallDelay = 40
Else



The way the script is set up there should be two calls to CheckNorth, two calls to CheckSouth, two calls to CheckEast, and
two calls to CheckWest. CheckEast had only one call from the sub CheckCaptain, none from Gold Multiball. Under this
situation you would have to complete Check Captain twice and the Gold Multiball once to get the east arrow. I put the call
to CheckEast in the Sub_Drain routine, so the check would be made after Gold Multiball.


If BallsOnPlayfield = 1 Then 'check multiballs
If MultiBallMode then
MultiBallMode = 0
'end multiball modes
PlayTheme 'stop the multiball song and start the theme
EndKraken
ResetJackpotMode
ResetSpecial
CheckEast
End4Winds
End If
End If


The table script, as written, has no limit to the number of balls that can accumulate and run on this table. I found that
after awhile my graphics card would just give up and the program would crash. To limit the maximum number of balls
active on the table I modified a line of code in the Sub AddBall routine. I suppose that number could go up for more
powerful graphics cards, but with 4 balls, I think the scoring is frenzied enough!

Sub NewBall()
If BallsOnPlayfield + PortRoyalLockedBalls = 4 then exit sub
BallRelease.CreateBall
BallsOnPlayfield = BallsOnPlayfield + 1
BallRelease.Kick 90, 8
PlaySound "ballrel"
End Sub

If awards that light the north, south, east, and west arrows are made through the LiarsDice or other means ( not
by lighting the two lamps on each side of N S E W), it is possible to start Four Winds Multiball without lighting
all the lamps on the steering wheel. I had to change the routine to start Four Winds Multiball to look at "all"
the lights on the wheel:

Sub Check4Winds 'check all the wheel lights are on
If FourWindsStarted Then
AwardSuperJackpot
Else
If LastSwitchHit = "sw16" then
If l2.state = 1 then
If l3.state = 1 then
If l4.state = 1 then
If l5.state = 1 then
If l6.state = 1 then
If l7.state = 1 then
If l8.state = 1 then
If l9.state = 1 then
If l49.state = 1 then
If l50.state = 1 then
If l51.state = 1 then
If l52.state = 1 then
Start4Winds
End If
End If
End If
End If
End If
End If
End If
End If
End If
End If
End If
End If
End If
End If
End Sub

Also, once Four Winds Multiball completes, only the 4 NSEW arrows became unlit. I added some more lines, so all the lights on
the wheel would go out, requiring you to accomplish all the goals a second time to enable Four Winds Multiball.


Sub End4Winds
If FourWindsStarted Then
l61.State = 0
LightSeqWheel.StopPlay
l49.State = 0 'reset north, east, south and west
l50.State = 0
l51.State = 0
l52.State = 0
l2.State = 0
l3.State = 0
l4.State = 0
l5.State = 0
l6.State = 0
l7.State = 0
l8.State = 0
l9.State = 0
FourWindsStarted = 0
End If
End Sub


There are other issues because modes are running concurrently with one another. For example you could receive an
extra ball and it would be cancelled out and superceded by a mode that starts a 30 second ball saver. Or while you
are in ballsaver mode, you could receive the award of an extra ball that would change the situation. There are also
a few sound issues that could be worked on. I think all the major stuff is taken care of though. As with any changes,
I hope none of these foul up your logic in any other way. Thanks J.P.

Edited by sast05, 07 February 2012 - 01:24 AM.

[RipleYYY]

just 1 test game on the Rosve mod today, and 323M...

JP, this is too easy, no doubt lots of us will round the clock in less than a week > what about adding a digit, or better modify the script to get points divided /10

[Flying Dutchman]

Update 101:

Added the bug fixes by sast05

FanTasTic Table JPSalas!

Thanks again!

Cheers,
FD.

[tamoore]

just 1 test game on the Rosve mod today, and 323M...

JP, this is too easy, no doubt lots of us will round the clock in less than a week > what about adding a digit, or better modify the script to get points divided /10

I've got an idea: How about you adding a digit, or modifying the script to do what you want it to do?

[karlojule]

thank you very much for this masterpiece. the only problem i had: wasn´t possible to get one of the extra balls which were lit

[sast05]

just 1 test game on the Rosve mod today, and 323M...

JP, this is too easy, no doubt lots of us will round the clock in less than a week > what about adding a digit, or better modify the script to get points divided /10

A good player could easily "overflow" the score, and chop off the "ball in play" digit.

[TedB]

Very entertaining table! Love the lay-out, sounds, music, theme, rules and graphics.... hmm... that is everything is it?
This is a table I will keep playing for quite a while.

Thanks JP!