Jump to content



Photo
- - - - -

comet vp9 FS


  • Please log in to reply
47 replies to this topic

#41 kruge99

kruge99

    Pinball Wizard

  • VPF Staff
  • 3,901 posts
  • Location:Markham, Ont.

  • Flag: Canada

  • Favorite Pinball: Black Knight, High Speed and Pin*Bot



Posted 15 March 2011 - 07:34 PM

Wicked!!!!


Best Regards,
Todd.

[proud owner of a Williams Solar Fire]

- It's called "The American Dream" because you have to be asleep to believe it.
George Carlin
- Truly great madness cannot be achieved without significant intelligence.
Henrik Tikkanen
- "Reality check, Michelle, Talk about composure, Total lack of. He's a man-- About-- 12 Feet Tall--"
Carrie Kelly
Posted Image

#42 MRCMRC

MRCMRC

    Enthusiast

  • Members
  • PipPipPip
  • 196 posts

  • Flag: Spain

  • Favorite Pinball: Canasta 86

Posted 30 March 2012 - 05:54 PM

Thanks for this table. Just added to my cabinet.

Found a small bug with plunger animation. Solved it adding pcount=0 at the end of line 150 of script:

CODE
If keycode = PlungerKey Then Plunger.PullBack:PKey=1:Pcount = 0:PTime.Enabled = 1


#43 kruge99

kruge99

    Pinball Wizard

  • VPF Staff
  • 3,901 posts
  • Location:Markham, Ont.

  • Flag: Canada

  • Favorite Pinball: Black Knight, High Speed and Pin*Bot



Posted 30 March 2012 - 06:53 PM

QUOTE (MRCMRC @ Mar 30 2012, 12:54 PM) <{POST_SNAPBACK}>
Thanks for this table. Just added to my cabinet.

Found a small bug with plunger animation. Solved it adding pcount=0 at the end of line 150 of script:

CODE
If keycode = PlungerKey Then Plunger.PullBack:PKey=1:Pcount = 0:PTime.Enabled = 1


Please don't take this the wrong way but... that seems a little redundant isn't it? Considering that setting is right before the PTime.Enabled =1 part... think.gif or is this picture missing the magnifying glasses or something? think.gif
[proud owner of a Williams Solar Fire]

- It's called "The American Dream" because you have to be asleep to believe it.
George Carlin
- Truly great madness cannot be achieved without significant intelligence.
Henrik Tikkanen
- "Reality check, Michelle, Talk about composure, Total lack of. He's a man-- About-- 12 Feet Tall--"
Carrie Kelly
Posted Image

#44 MRCMRC

MRCMRC

    Enthusiast

  • Members
  • PipPipPip
  • 196 posts

  • Flag: Spain

  • Favorite Pinball: Canasta 86

Posted 30 March 2012 - 07:57 PM

QUOTE (kruge99 @ Mar 30 2012, 07:53 PM) <{POST_SNAPBACK}>
Please don't take this the wrong way but... that seems a little redundant isn't it? Considering that setting is right before the PTime.Enabled =1 part... think.gif or is this picture missing the magnifying glasses or something? think.gif


Just try it and see the (small) difference.

#45 kruge99

kruge99

    Pinball Wizard

  • VPF Staff
  • 3,901 posts
  • Location:Markham, Ont.

  • Flag: Canada

  • Favorite Pinball: Black Knight, High Speed and Pin*Bot



Posted 30 March 2012 - 10:16 PM

QUOTE (MRCMRC @ Mar 30 2012, 02:57 PM) <{POST_SNAPBACK}>
QUOTE (kruge99 @ Mar 30 2012, 07:53 PM) <{POST_SNAPBACK}>
Please don't take this the wrong way but... that seems a little redundant isn't it? Considering that setting is right before the PTime.Enabled =1 part... think.gif or is this picture missing the magnifying glasses or something? think.gif


Just try it and see the (small) difference.


OK - I'll bite - WHAT difference. I was one of the BETA testers because I have knowledge of the real table. I have played Comet many hundreds of times - both the real game as well as "Team Unclewilly's" VP re-creation.

Don't just throw out a bug report and NOT present any evidence, that's borderline rude. So I ask again, please what bug you are seeing and maybe post a video or a screenshot!


Best Regards,
Todd.

[proud owner of a Williams Solar Fire]

- It's called "The American Dream" because you have to be asleep to believe it.
George Carlin
- Truly great madness cannot be achieved without significant intelligence.
Henrik Tikkanen
- "Reality check, Michelle, Talk about composure, Total lack of. He's a man-- About-- 12 Feet Tall--"
Carrie Kelly
Posted Image

#46 MRCMRC

MRCMRC

    Enthusiast

  • Members
  • PipPipPip
  • 196 posts

  • Flag: Spain

  • Favorite Pinball: Canasta 86

Posted 30 March 2012 - 10:45 PM

As I've said, the bug is very very slight, and as I've said, has to do with the plunger animation.

Unclewilly has used a variable called Pcount for controlling the plunger reel. This variable should be initialized after each pull and release cycles, or just before them (Pcount=0). In this case, the Pcount variable is not initialized before the pull cycle, so then it has the value that achieved in the last release cycle (probably 5). So, the tiny bug is that the first plunger pull you make works perfect, but all the rest have a small "jump", since the animation of 25 frames go from frame 0 to frame 6 directly. Just a minor bug, as I've said.

My comment was addressed to Unclewilly, saying thanks for his great table that I've just added to my cab, and showing to him this small bug, thinking that he maybe would want to correct it on the next release. I think I've just covered one of the two goals that a support topic is supposed to have: "reporting feedback to table creators" (the other could be "asking for help"). And I'm pretty sure that when UW see the script line I've posted, he will see what I mean. This additional explanation is not necessary to him.

#47 kruge99

kruge99

    Pinball Wizard

  • VPF Staff
  • 3,901 posts
  • Location:Markham, Ont.

  • Flag: Canada

  • Favorite Pinball: Black Knight, High Speed and Pin*Bot



Posted 30 March 2012 - 10:54 PM

QUOTE (MRCMRC @ Mar 30 2012, 05:45 PM) <{POST_SNAPBACK}>
As I've said, the bug is very very slight, and as I've said, has to do with the plunger animation.

Unclewilly has used a variable called Pcount for controlling the plunger reel. This variable should be initialized after each pull and release cycles, or just before them (Pcount=0). In this case, the Pcount variable is not initialized before the pull cycle, so then it has the value that achieved in the last release cycle (probably 5). So, the tiny bug is that the first plunger pull you make works perfect, but all the rest have a small "jump", since the animation of 25 frames go from frame 0 to frame 6 directly. Just a minor bug, as I've said.

My comment was addressed to Unclewilly, saying thanks for his great table that I've just added to my cab, and showing to him this small bug, thinking that he maybe would want to correct it on the next release. I think I've just covered one of the two goals that a support topic is supposed to have: "reporting feedback to table creators" (the other could be "asking for help"). And I'm pretty sure that when UW see the script line I've posted, he will see what I mean. This additional explanation is not necessary to him.


Then why not post a video showing before and after results? I have used both a keyboard and the nanotech diy plunger kit on this table and it doesn't jump for me otherwise I would have reported it to UW as such.

If it's so slight as you say, how could anyone be expected to see it without some sort of picture? Also, every table that uses similar code for the plunger animation would also be affected, not just this one. (I think I should know because I've modded over 100 tables on my pincab to make the animated plunger work with the nanotech diy kit using the same code.)

A picture (in this case a video) is worth a thousand words as the saying goes.


Best Regards,
Todd.
[proud owner of a Williams Solar Fire]

- It's called "The American Dream" because you have to be asleep to believe it.
George Carlin
- Truly great madness cannot be achieved without significant intelligence.
Henrik Tikkanen
- "Reality check, Michelle, Talk about composure, Total lack of. He's a man-- About-- 12 Feet Tall--"
Carrie Kelly
Posted Image

#48 MRCMRC

MRCMRC

    Enthusiast

  • Members
  • PipPipPip
  • 196 posts

  • Flag: Spain

  • Favorite Pinball: Canasta 86

Posted 30 March 2012 - 11:59 PM

Sorry, I haven't got the means for recording such a video. I only was trying to help. I didn't imagine that I'd need a multimedia evidence before reporting the bug, and I don't want to keep defending it. So let's forget about the last part of my first post.

Thanks againg to UW for this table.

EDIT: Unclewilly, since you have doubled the number of frames of plunger animation, I suggest to change the PTime timer from 60 to 30 so the animation time matches the real plunger pullback time.

Edited by MRCMRC, 31 March 2012 - 03:29 PM.