1790 replies to this topic

[Thalamus]

Wait ? Are you saying that your on the newest SC dll but, using setup.exe from the regular ? I'm quite sure I tried that too, but, I had no luck.

[RYSr]

 

Just tried vpinmame sc 3.4 221 as well as v165 from the link on the Sambuild thread and setup exe crashes on my Win 8.1 PC. I don't have a Get hub acct to try the latest v279. Sambuild 3.2b work fine. But doesn't have the newer rom entries I wanted. I tried it on the new Cheech & Chong table and it does not error on finding the ROM file now, but still doesn't run it on table start.

 

Tried creating a new empty vpinmame folder and put the ver 3.4 221 in it and ran install and setup still crashes,

 

new: Tried creating a new folder with the VPinMAME34_beta from the first post in this thread. Uninstalled and reinstalled and tried running setup/test and it worked, then Cheech & Chong table and it worked.

 

I then tried coping the sc-3.4-221 setup.exe into it and test still worked. Then copied the vpinmame.dll to it and then crash happened.

 

Here, from Github latest build

VPinMAME-sc-3.4-279-50e07cf-win-x86

 

May still blow up on windows 7, looking for power supply to win 7 laptop.
It would have to be the one with the funky 3 pin PSU

 

@Thalamus
WHat is the build date on the last one that works for you in windows 7?

If i find the damned PSU, i could start running through the past builds to see when it hits the toilet.

 

I just tried the v279 from your link. Still have same problem. If I copy the vpinmame.dll and the setup.exe from SAMBuild33b back over the v270 files and run install test works again! I have tried the SC 3.4 165, 221, and now the 279 versions and they all have the crash when pressing test..

 

Just to be clear the tables work, it's only when you try to use the test button in setup that it crashes!!

Edited by RYSr, 18 July 2021 - 11:29 PM.

[Outhere]

Wait ? Are you saying that your on the newest SC dll but, using setup.exe from the regular ? I'm quite sure I tried that too, but, I had no luck.

If I use this all is good including color Rom's
And i do not use SAMBuild
VPinMAME-sc-3.4-279-50e07cf-win-x86
https://github.com/v...runs/1027799532

[RYSr]

 

Wait ? Are you saying that your on the newest SC dll but, using setup.exe from the regular ? I'm quite sure I tried that too, but, I had no luck.

If I use this all is good including color Rom's
And i do not use SAMBuild
VPinMAME-sc-3.4-279-50e07cf-win-x86
https://github.com/v...runs/1027799532

 

Yes this version sc (SAM version) 279  runs the tables properly, but does the test button in vpinmame setup work for you? It doesn't for me!

Edited by RYSr, 18 July 2021 - 11:33 PM.

[Outhere]

 

 

Wait ? Are you saying that your on the newest SC dll but, using setup.exe from the regular ? I'm quite sure I tried that too, but, I had no luck.

If I use this all is good including color Rom's
And i do not use SAMBuild
VPinMAME-sc-3.4-279-50e07cf-win-x86
https://github.com/v...runs/1027799532

 

Yes this version sc (SAM version) 279  runs the tables properly, but does the test button in vpinmame setup work for you? It doesn't for me!

 

Yes

[Thalamus]

Hmm. No, 279 isn't working here. It has the issue mentioned already. But, yes, working on Win10 for me too. Just not where I consider important

[wiesshund]

 

 

My mistake - No better
When I put a SAMBuild over it and run setup.exe and click on TEST VPinMAME closes
 

just curious, rename your vpinmame folder so it is backed up and safe

make a new vpinmame folder and put that build into it

does it still implode when clicking test?
I realize there wont be any roms there to test, but for your issue, it wont matter

 

Do you also run windows 7?
I may have a laptop here with win 7 still on it, will have to look.

 

Doing this made no difference

using windows 10 - 2 computer same thing
 For now I'm using the new SC version from the github without SAMBuild

 

 

For all intents and puposes, SC is a SAM build
It supports Colored ROMs

[Thalamus]

Yes. SC is different still from the official. It used to be that you had to have SAM build, to play those SAM sterns. That is supported now in the official, approx since last x-mas if I remember correctly. To the best of my knowledge, SC should only now only included the color implementation from the official. And, obviously, there is some issues related to it. No clue as to where to look.

[jsm174]

The only difference with the SC builds in the CI is the inclusion of the `SAM_INCLUDE_COLORED` flag:

 

   https://github.com/v...pinmame.yml#L61

 

 

You could always build any of the versions with `--config Debug`

 

   https://github.com/v...pinmame.yml#L73

 

 

to get more info when it crashes. 

[RYSr]

The only difference with the SC builds in the CI is the inclusion of the `SAM_INCLUDE_COLORED` flag:

 

   https://github.com/v...pinmame.yml#L61

 

 

You could always build any of the versions with `--config Debug`

 

   https://github.com/v...pinmame.yml#L73

 

 

to get more info when it crashes. 

The SC version also includes the modified color ROM version in its ROM listings. IE: acd_168hc

[jsm174]

@RYSr - That is what the SAM_INCLUDE_COLORED flag does:

 

https://github.com/v...LORED&type=code

[Thalamus]

The only difference with the SC builds in the CI is the inclusion of the `SAM_INCLUDE_COLORED` flag:

 

   https://github.com/v...pinmame.yml#L61

 

 

You could always build any of the versions with `--config Debug`

 

   https://github.com/v...pinmame.yml#L73

 

 

to get more info when it crashes. 

You can't by any chance share a debug enabled setup.exe - and maybe even tell how to use it ? I tried to compile it and there is something not working on my end.

[jsm174]

@Thalamus -

 

Sure. I just created a new workflow that creates the debug versions. Artifacts are here:

 

https://github.com/j...runs/1046968151

[RYSr]

I just tried installing the VPinMAME-sc-3.4-279-50e07cf-win-x86 build on my CAB that is running Windows 10 and the test button works in setup as well as all the tables.

Edited by RYSr, 20 July 2021 - 01:55 AM.

[Thalamus]

@jsm174 / @toxie : Plot thickens. The debug build has no issue here. That is 281 from jsm174, 280 from official is still an issue. I tried just out of curiosity to run the debug setup.exe with the regular sc dll, it crashes like the regular setup.exe. So, the debug build didn't really help me pointing out where the problem lies.

[jsm174]

@Thalamus,

 

I just ran the CI in my fork one more time, this time removing upx compression on vpinmame. We were seeing strange behavior with upx, so this is just a shot in the dark. FYI, zero code changes from master.

 

 

VPinMAME:

https://github.com/j...runs/1048715684

 

VPinMAME-debug:

https://github.com/j...runs/1048715687

[Thalamus]

Unregister -> register -> test ... all OK !

 

Big hug @jsm174 / @toxie and whoever figured it out !! Didn't need the debug

[jsm174]

So, hopefully not boring everyone, I'll try to elaborate on upx some more. 

 

upx is an executable packer. The official version is 3.96 and from Jan 22, 2020.

 

Taking VPinMAME64.dll as an example, it can dramatically reduce the binary size -- 9650176 (9.7MB) to 1714688 bytes (1.7MB) 

 

 

When we started implementing Github CI, we noticed that VPinMAME (compressed with upx 3.96) would crash on Windows 10. 

 

UPX dev has evolved a ton since Jan 22, 2020, but they are not willing to make an official release. 

 

 

So what we did was download a upx binary from their github actions. The problem is artifacts are only good for 90 days. 

 

On Jun 19th, we had to bump the upx artifact. The CI is currently using:

 

https://github.com/u...44336050a0b242e

(https://github.com/u.../runs/775869948)

 

It looks like there have been a few patches since that artifact that could make a difference. (specifically: 

https://github.com/u...ba446a9dd2cc81c )

 

TLDR; I see a few options:

 

1) We remove upx from the ci and leave the binaries uncompressed

 

2) We try the latest upx artifact, and test all versions of everything (x86, x64, sc-x86, sx-x64, pinmame, pinmame32, etc)

 

bonus:

 

3) Once we find a working upx, we copy it to the repo so we don't go through this again in 90 days.  

Edited by jsm174, 20 July 2021 - 03:06 PM.

[Thalamus]

Hmm. You don't bore me. In fact, this kind of info I find it interesting. I'm very happy that you guys figured out what was the issue. Question is with compression vs non compress. Is it any faster loading ? I mean, if you compress, you have to decompress and with today fast hard drives, maybe loadin 15M instead of 2M isn't worth it ? Whatever you guys decide has my vote  

[RYSr]

Thanks for getting to the bottom of this.

Where/when can the average user (like me) download the corrected  SC version?