1790 replies to this topic

[jsm174]

@antisect - These are compiled with the SAM_INCLUDE_COLORED flag.

[antisect]

@antisect - These are compiled with the SAM_INCLUDE_COLORED flag.

 

ahhh, thanks

[GInsonic]

@antisect - These are compiled with the SAM_INCLUDE_COLORED flag.

I cloned the repository and "raw" compiling works flawlessly, could you please explain how to compile with this flag , thanks!

[jsm174]

I probably should make a wiki entry in the repo for this.

 

The CI uses CMake files for all the different builds. For all Windows builds, CMake generates a Visual Studio project file, that's similar to .vcxproj files found in the repo. 

(We keep updating the CMake files as I missed a few compile options)

 

Anyway, we went with CMake because you can more easily see the differences between platforms and architectures rather than looking in .vcxproj or makefiles.

 

If you look in the workflows folder you can see the compile process. For example:

 

https://github.com/v...nmame32.yml#L43

 

So if I was building PinMAME32 SAM COLOR x86, I would:

copy cmake\pinmame32\CMakeLists_win-x86.txt CMakeLists.txt
cmake -D CMAKE_CXX_FLAGS=/DSAM_INCLUDE_COLORED -G "Visual Studio 16 2019" -A Win32 -B build
cmake --build build --config Release

If you're sticking with Visual Studio, just add a SAM_INCLUDE_COLORED to the PreprocessorDefinitions

Edited by jsm174, 24 March 2021 - 12:37 PM.

[GInsonic]

Many thanks! Yes, I'm currently using Visual Studio 2019, so I added it as described!

[GInsonic]

Sorry to bother you again, but if I now compile PinMame32 using the color flag, should the resulting dll contain the color rom names same as SAM build? I did, and it seems, that it does not.

[jsm174]

@GInsonic

 

PinMAME + PinMAME32 outputs exe's

VPinMAME outputs a dll

 

I did notice that the color flag does not seem to do anything to x64 builds for PinMAME + PinMAME32.

 

You can check with the prereleases here:

 

https://github.com/v...3.4-163-b49f37a

 

(These are the latest code)

[GInsonic]

@GInsonic

 

PinMAME + PinMAME32 outputs exe's

VPinMAME outputs a dll

 

I did notice that the color flag does not seem to do anything to x64 builds for PinMAME + PinMAME32.

 

Thanks again, I figured it out meanwhile. I added the Preprocessor Definition to the wrong project (PinMame32 instead of Visual Pinmame) 

Now it works like a charm! Thanks for all your efforts guys, MUCH appreciated!

Edited by GInsonic, 24 March 2021 - 04:04 PM.

[toxie]

I did notice that the color flag does not seem to do anything to x64 builds for PinMAME + PinMAME32.

 

This part i cannot explain at all..  :/

From the code side of things, there are basically only 2 places (driver.c & sam.c) where this can affect things, and both of them are not specific to any compilation target, but are triggered for everything then.

[jsm174]

ok. I'll run through it again just to make sure I'm not crazy    : ) 

Edited by jsm174, 25 March 2021 - 08:25 PM.

[GInsonic]

ok. I'll run through it again just to make sure I'm not crazy    : ) 

I'm pretty sure, you are not

 

I now compiled the x64 release using the color flag and I can confirm, that the colored roms are now active, same as in the x86 version!

[toxie]

Also in PinMAME.exe and PinMAME32.exe ??

[fourbanks]

@GInsonic

 

PinMAME + PinMAME32 outputs exe's

VPinMAME outputs a dll

 

I did notice that the color flag does not seem to do anything to x64 builds for PinMAME + PinMAME32.

 

You can check with the prereleases here:

 

https://github.com/v...3.4-163-b49f37a

 

(These are the latest code)

that page is not working 

[jsm174]

@fourbanks, Yes, I deleted that pre-release because we were missing two important compile options /GL and /LTCG.

 

New prerelease is here:

 

https://github.com/v...3.4-165-c43e706

 

Also, all releases can be found here:

 

https://github.com/v...inmame/releases

[fourbanks]

@fourbanks, Yes, I deleted that pre-release because we were missing two important compile options /GL and /LTCG.

 

New prerelease is here:

 

https://github.com/v...3.4-165-c43e706

 

Also, all releases can be found here:

 

https://github.com/v...inmame/releases

thank you

[GInsonic]

Also in PinMAME.exe and PinMAME32.exe ??

 

I only tested VPinmame.dll yet, but I will try!

 

Edit:

 

In PinMAME32.exe the color roms are visible, but I am having troubles to compile x64 (only compiling the dll works) 

Edited by GInsonic, 26 March 2021 - 07:06 PM.

[toxie]

x64 would be interesting, yes. what troubles do have?

[Thalamus]

Feel kind of stupid, but, I was expecting that once you did a checkout of pinmame and vpinball I should not at least get errors of missing files ?

 

I can't seem to find VPinMame.h ?!

[jsm174]

@Thalamus, 

 

Some files (like the one your are talking about) are created during the compile process:

 

https://github.com/v...xproj#L190-L197

 

Here is some information on the MIDL compiler:

 

https://docs.microso...midl-start-page

[toxie]

Feel kind of stupid, but, I was expecting that once you did a checkout of pinmame and vpinball I should not at least get errors of missing files ?

 

I can't seem to find VPinMame.h ?!

Did you use an older .sln or .vcproj to compile?