616 replies to this topic

[jpsalas]

I was just going to write that VPX with symbols didn't crashed yesterday for about 3 hours, and today for about 1 hour. And I did what I used to do, editing a new file, opening a vpt table copying some objects, etc.  But when I clicked on the X button to quit the editor then it crashed Let's see if there is any info about what happened.

 

https://app.box.com/...9czhbh3972wz1p1

 

JP

[hanzoverfist]

I get a lot of crashing also, but I find it only crashes when data is not saved, (now you will say well data is not saved anytime you do anything) true but hear me out.. If I modify my table then save then run a simulation (play it) it does not crash, but if I modify my table then don't save in the same conditions then simulate, the table will crash. And it only seems to crash with the larger tables, and another observation is whenever it does crash when I run a simulation pinmame either failed to launch or vpinball never reached vpinmame launch before crashing.

 

anyway these are just observations, and I have not been able to produce exact steps to reproduce, only that the above conditions I mentioned occur frequently.

 

EDIT: same as JP above , I have mentioned it already, the copying of data from one VPX -> another VPX in the same editor instance can cause crashes, if not immediately after closing the host VPX or sometime thereafter.

Edited by hanzoverfist, 23 June 2017 - 04:56 AM.

[toxie]

Please also try to get a crash dump or maybe even try to run with a debugger attached directly (in your case), so we can nail it down..

[toxie]

The crash i fear is for Fuzzel to debug.. This one i could only try to avoid having it crash VPX, but not curing the actual problem that caused it.. :/

Cause i do not even understand why the last piece of code is even called here in this case..

 

@Fuzzel: callstack (line 159 of propbrowser.cpp, g_pvp is NULL):

     VPinballX.exe!SmartBrowser::CreateFromDispatch(HWND__ * hwndParent, Vector<ISelect> * pvsel) Line 159    C++
     VPinballX.exe!VPinball::ParseCommand(unsigned int code, HWND__ * hwnd, unsigned int notify) Line 1573    C++
     VPinballX.exe!VPinball::SetEnableToolbar() Line 1664    C++
     VPinballX.exe!TableWndProc(HWND__ * hwnd, unsigned int uMsg, unsigned int wParam, long lParam) Line 7457    C++
 

[fuzzel]

Ok thanks I'll take a look

[toxie]

Cool, thanks.. Although i fear that this is not related to the other crashes you guys are seeing..

[fuzzel]

It looks like we have a race condition here when accessing collections and/or multi selected elements. I added a critical section to serialize the access to the data. 

 

@Toxie, can you post a new debug build, because I'm behind a firewall at the moment that blocks exe files

[randr]

Well I've been getting a ton of crashing too! I thought it was darks fault with image sizes! Lmao! Glad you guys are on it! Thank you

[toxie]

Took a while, sorry, here the next update..

Edited by toxie, 23 June 2017 - 07:22 PM.

[Thalamus]

I thought you devs needed a break and now your debugging like your life depends on it - you guys never ceases to amaze me with your lever of dedication. I kind of feel bad posting bugs when you've already said you need a break

[jpsalas]

I didn't thought you should come with an update already, so I was testing with the first VPX with the symbols. Anyway here it is a crash dump files I just got using that last VPX debug with the symbols. The crash happened in the editor while selecting a few walls with the mouse, by dragging a rectangle with the mouse to select the objects. I'm not sure if the crash happened when I released the mouse button or if I never finished to draw the rectangle.

 

 

 

[wrd1972]

Took a while, sorry, here the next update:

Toxie,

I tried this and could not get BOP to crash. Where there issues resolved with this spin of code? Or should it be assumed that it should crash (relative to 10.3 official), if I just wait longer?

[fuzzel]

I hope that the new version fixes the crashes

[toxie]

I thought you devs needed a break and now your debugging like your life depends on it - you guys never ceases to amaze me with your lever of dedication. I kind of feel bad posting bugs when you've already said you need a break

 

True, but here we're not developing a new feature or have to test something/fiddle around on our own to make it crash or behave incorrect.

We get a dump and (usually) get a good impression of what's going on directly from that.

I didn't thought you should come with an update already, so I was testing with the first VPX with the symbols. Anyway here it is a crash dump files I just got using that last VPX debug with the symbols. The crash happened in the editor while selecting a few walls with the mouse, by dragging a rectangle with the mouse to select the objects. I'm not sure if the crash happened when I released the mouse button or if I never finished to draw the rectangle.

 

10.3crash_mouse-select.zip

 

 

 

i'm a bit confused now, so is this from the first releasewithsymbols build i posted or the one i posted two above your post (which includes fuzzels fixes)?

 

EDIT: unfortunately the dump is anway broken for whatever reason, at least i cannot open it in visual studio..  :/

Edited by toxie, 23 June 2017 - 07:20 PM.

[toxie]

and one more with some more tiny things fixed (e.g. not fixing any crashes, but i'll remove the other debuggable variants to avoid further confusions anyway, please continue to test with that version and post the dump files if it crashes, thanks!!):

Attached Files

•  ReleaseWithSymbols.zip   11.49MB   6 downloads

Edited by toxie, 23 June 2017 - 07:21 PM.

[jpsalas]

First crash with this latest "ReleaseWithSymbols". It happened when closing one of the tables. I had 3 tables open, and I copied a few objects from different tables, then I opened another table to copy a new object and it was the wrong table so I clicked on the X icon to close this table, and then it crashed. It had been working fine for several hours without a crash, and I run the table many times to check the changes, the table does not use vpinmame just now and the script is empty.

 

https://app.box.com/...gohv1b54m3o2grd

 

Remember that I use Windows 10 LTSB, so I'm not sure how good this version of windows plays with VPX, but it seems very stable. I installed the directx9 of course and the latest Nvidia drivers for the GTX 680.

 

JP

[toxie]

Thanks.. @Fuzzel: Maybe one for you again (as i do not understand that part that well)? It crashes on ppt->Release(); in vpinball.cpp in CloseTable().

[fuzzel]

Will check it but not today

[jpsalas]

No problem fuzzel, the last editor works very well, and it has not crashed for hours.  I have been working with it many hours today, and it has crashed only two times, both times when closing  the editor.

[fuzzel]

That's good to know...thanks