32 replies to this topic

[Pmax65]

Hi Halen,

 

... is it possible to make this in Drakor table?

I suppose yes, meaning that I'm just newbie here, but looking inside the script it just misses the LampTimer_Timer sub.

 

Do exactly what you did for the Polar express except that you must place the last piece of patch into the DisplayTimer_Timer sub  instead of the missing LampTimer_Timer sub.

and copy this lines below just before that piece of patch, always there into the DisplayTimer_Timer sub:

    Dim chgLamp, ii
    chgLamp = Controller.ChangedLamps
    If Not IsEmpty(chgLamp) Then
        For ii = 0 To UBound(chgLamp)
            LampState(chgLamp(ii, 0) ) = chgLamp(ii, 1)   
        Next
    End If

and just before the DisplayTimer_Timer sub place this line:

Dim LampState(200)

I would do it for you, but now I'm installing some tables in my cabinet (I'm doing my collection) and here in Italy it's 00:23AM.

I would like to go sleep before 2:00AM   
Anyways I promise you that tomorrow night I'll be back to you and in case you'll have any issue with the Drakor table we surely fix it.

In the meantime have fun with your cabinet.

 

Massimo

Edited by Pmax65, 20 February 2019 - 11:28 PM.

[Halen]

Thanks!!! I will try tomorrow.

[Pmax65]

Hi Halen,

Try the attached file Drakor.txt.

It should work but in line 77 you could experience an error in case l20 lamp didn't exist in  that table.

In this case you should look on the table for a lamp which stays off during the final match procedure and lights on after it and replace that l20 with the name of that lamp.

Note that the code comprised in the Do ... Loop Until process (shown below) is just useful to fix the losing of the hi-score when you exit the table after the game-over but before the final match procedure has ended. This part of the patch doesn't work if the table is launched from the PinballX front-end because it seems that it forces the VPinMAME exit without waiting for the complete program ending.

In that case the hi-score is not fully lost, but because the other parts of the patch still work and at the next launch of the table the hi-score of the last session which had exited correctly is recovered anyway, thus only the eventual hi-score of the very last session is definitively lost.

Sub NVramPatchExit
	If LampState(GameOverLampID) Then 
		Kill GetNVramPath + "\" + cGameName + ".nvb"
		Do
			DisplayTimer_Timer	' This loop is needed to avoid the NVram reset (losing the hi-score and credits) 
		Loop Until l20.State = 1	' when the game is over but the match procedure isn't still ended
	End If
End Sub

Attached Files

•  Drakor.txt   21.87KB   5 downloads

[Halen]

Pmax65,

 

I test the script attached and i have problem with patch: Fill LampState array for NVram patch. I erase the patch and test the table and works fine.

 

Thanks man!!! I have no way to thank you for your help and patience !!!

[Pmax65]

Hi Halen,

I'm not sure I got your point, when you wrote that you deleted the patch, are you meaning that you removed all this code?

' =============================================================================================================
' Fill LampState array for NVram patch
' =============================================================================================================
 	Dim chgLamp, num, chg, ii
 	chgLamp = Controller.ChangedLamps
	If Not IsEmpty(chgLamp)Then
        	For ii = 0 To UBound(chgLamp)
        		LampState(chgLamp(ii, 0) ) = chgLamp(ii, 1)
	        Next
	End If
' =============================================================================================================
' =============================================================================================================

If you removed all that, the whole patch don't works at all because the controller doesn't return any signal for the game over lamp (LampState(149)).

The code I sent this morning had a bug indeed. You should change the code above as follows:

' =============================================================================================================
' Fill LampState array for NVram patch
' =============================================================================================================
 	Dim chgLamp
 	chgLamp = Controller.ChangedLamps
	If Not IsEmpty(chgLamp)Then
        	For ii = 0 To UBound(chgLamp)
        		LampState(chgLamp(ii, 0) ) = chgLamp(ii, 1)
	        Next
	End If
' =============================================================================================================
' =============================================================================================================

Note that the variables [num], [chg] and [ii] are no longer there because they are already defined in that sub (my mistake). Below you find the file already fixed.

 

 

Try this way and tell me how it works.

 

Attached Files

•  DrakorPch.txt   21.86KB   5 downloads

[Halen]

Yes!!!!

 

Works like a charm!!!

 

Thanks man!!!

[Pmax65]

Nice to read that.

 

Have fun!

 

Massimo

[Zedixair]

On SHARK table, because I had the "missing ball" problem, I tried the patched script done by @Pmax65 (TY for your appreciated work).

 

It solved the issue of the missing ball, but created another strange problem: when I use the flippers, one part of them doesn't move. It's like the above black and white parts do the normal job, but the black bottom parts of the flippers stay stuck and don't move ! I run an updated VPX 10.6 with SamBuild beta 3.2 rev r4689. With the original script of Shark, the flippers were working...

 

Did someone else have this weird issue ? How to fix that ?

[Pmax65]

It solved the issue of the missing ball, but created another strange problem: when I use the flippers, one part of them doesn't move. It's like the above black and white parts do the normal job, but the black bottom parts of the flippers stay stuck and don't move ! 

Hi Zedixair,

the great JpSalas reissued the table with the mod embedded, try it at this link:

 

https://www.vpforums...&showfile=13164

 

Maybe that doing the mods you inadvertently removed some lines from the script.

 

Have a great day.

 

Massimo

[Thalamus]

@pmax65 : Thank you for coming up with the solution in the first place. Nothing is better than seeing the author themselves including you're work into the table so thumbs up to you !

[Pmax65]

@pmax65 : Thank you for coming up with the solution in the first place. Nothing is better than seeing the author themselves including you're work into the table so thumbs up to you !

Hi Thalamus,

this is a community of people who share the same (great  ) hobby, and I think that it works when anybody shares their own experience with the others. 

JpSalas is not just a great pinball designer but also a gentleman who is a pleasure chat with, I privately asked him a tip about another pinball and after highlighting him this thread he decided to embed my mods in the tables which needed it (Shark and Mr Black). 

 

Now I'm trying to embed it also in other tables because there is an another hidden bug (it's not a JpSalas' table bug, it's the Taito controller that has this bug of not clearing the unnecessarily non volatile RAM of the board).

This bug happens on all Taito's tables when you exit the table after having ending the game (the game-over lamp is already on) but the ending match sequence is still not ended. The bug clears all the RAM the hi-score and the credit counter.

My mod on the Shark table fixes it outside of PinballX and inside it loses only the last session data.

But for the Cavaleiro Negro table I'm in trouble with end of match sequence recognition. The table unloads but it seems that the VpinMAME controller doesn't want to exit no more  . 

 

Have a great day.

 

Massimo

[Zedixair]

Hi Pmax65,

thank you for your answer and your advice. I'll try the updated version at the link you mentioned.

 

Have a great day too.

[Zedixair]

@Pmax65 : you were right, the updated version works perfectly, thanks again !